-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch to using datafusion to parse functions #1793
Conversation
ACTION NEEDED Lance follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
I've updated #1129 with the incompatibilities I observed this time. |
What do you mean? can't you just nest GetIndexedField calls? |
|
Does this fix #1115? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me :)
Looks like it. I've added a regression test for |
(Sorry just merged a PR that added some conflicts. Should be easy to resolve though.) |
dac9799
to
c07a427
Compare
My original plan was to use DF for parsing expressions (not just functions). However, I ran into some issues:
x.y
but notx.y.z
)List
and notFixedSizeList
So this PR only uses DF to parse the functions. In addition, we keep the legacy path to handle the
is_valid
function for DuckDb.Closes #1115
Closes #1784