Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump version to 0.11 to reflect breaking changes #2332

Merged
merged 2 commits into from
May 14, 2024

Conversation

westonpace
Copy link
Contributor

33d576f introduced a breaking change but did not bump the minor version. This PR only bumps the minor version.

@github-actions github-actions bot added the chore label May 13, 2024
@westonpace
Copy link
Contributor Author

@wjones127

It looks like check_versions.py is still broken.

I notice it only seems to be looking at the minor/patch versions when looking at the latest release:

    latest_release = repo.get_latest_release()
    last_version = parse_version(latest_release.tag_name[1:])

However, when looking at the current code it seems to be using major/minor/patch. Is this correct or am I missing something?

    new_version = parse_version(get_versions())

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (fe2d874) to head (931a21e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2332      +/-   ##
==========================================
+ Coverage   80.64%   80.66%   +0.02%     
==========================================
  Files         192      192              
  Lines       56684    56684              
  Branches    56684    56684              
==========================================
+ Hits        45713    45725      +12     
+ Misses       8404     8394      -10     
+ Partials     2567     2565       -2     
Flag Coverage Δ
unittests 80.66% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127
Copy link
Contributor

I notice it only seems to be looking at the minor/patch versions when looking at the latest release:

The [1:] is chopping the v off of the tag. Though not sure if that's what you are talking about here.

@wjones127
Copy link
Contributor

This is very weird. Maybe actions/checkout@v2 needs to be updated to actions/checkout@v4? I wonder if it's checking out the wrong branch somehow.

@westonpace
Copy link
Contributor Author

The [1:] is chopping the v off of the tag. Though not sure if that's what you are talking about here.

Ah, in my brain I was thinking it was already split at this point. You're right that chopping off the v should be safe.

…is pulling the wrong PR to check for latest version otherwise
@westonpace
Copy link
Contributor Author

@wjones127 because the action was run as pull_request_target it does not run in the context of the PR but rather in the context of the main branch. So the latest version was appearing as 0.10 even though this PR bumps it to 0.11.

Since the PR doesn't need access to any secrets I went ahead and changed it to pull_request.

However, another way we could fix this is to change the action to specify the SHA to checkout manually: actions/checkout#518 (comment)

This should be safe since we aren't actually executing any code in the checked out repo, only looking at the version files.

Let me know if you have a preference for one approach over the other.

@westonpace westonpace requested a review from wjones127 May 14, 2024 15:55
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull_request sounds good to me. Thanks for figuring the out.

@westonpace westonpace merged commit 1e9e47f into lancedb:main May 14, 2024
17 of 21 checks passed
@westonpace westonpace deleted the chore/bump-minor-to-11 branch May 14, 2024 17:18
eddyxu pushed a commit that referenced this pull request May 16, 2024
33d576f
introduced a breaking change but did not bump the minor version. This PR
only bumps the minor version.
wjones127 added a commit that referenced this pull request May 17, 2024
Earlier in
#2332 (comment) we
switched to `pull_request` events to checkout the correct PR. However,
in those actions, GHA doesn't have permissions to label PRs, so that
change broke the labeler job. This switches back of
`pull_request_target`, but adds code to checkout the correct branch when
checking for breaking changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants