Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert scan args into struct #2976

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

westonpace
Copy link
Contributor

I was trying to add a new option (load_blobs) to the scan exec and realized the args had gotten a little out of control. I refactored them into a struct. I've since abandoned my original idea (load_blobs) but wanted to see if others felt the refactor was worth keeping.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 89.79592% with 15 lines in your changes missing coverage. Please review.

Project coverage is 78.20%. Comparing base (19d947e) to head (accb77c).

Files with missing lines Patch % Lines
rust/lance/src/dataset/write/merge_insert.rs 0.00% 7 Missing ⚠️
rust/lance/src/io/exec/scan.rs 93.22% 2 Missing and 2 partials ⚠️
rust/lance/src/dataset/fragment.rs 94.00% 0 Missing and 3 partials ⚠️
rust/lance/src/io/exec/pushdown_scan.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2976      +/-   ##
==========================================
- Coverage   78.23%   78.20%   -0.03%     
==========================================
  Files         239      239              
  Lines       76594    76576      -18     
  Branches    76594    76576      -18     
==========================================
- Hits        59925    59888      -37     
- Misses      13614    13624      +10     
- Partials     3055     3064       +9     
Flag Coverage Δ
unittests 78.20% <89.79%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Optionally, I think you can make a few tests clearer by only setting the relevant properties.

rust/lance/src/io/exec/take.rs Outdated Show resolved Hide resolved
rust/lance/src/io/exec/take.rs Outdated Show resolved Hide resolved
rust/lance/src/io/exec/take.rs Outdated Show resolved Hide resolved
rust/lance/src/io/exec/take.rs Outdated Show resolved Hide resolved
rust/lance/src/io/exec/take.rs Outdated Show resolved Hide resolved
@westonpace westonpace merged commit 631e9bf into lancedb:main Oct 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants