-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: convert scan args into struct #2976
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2976 +/- ##
==========================================
- Coverage 78.23% 78.20% -0.03%
==========================================
Files 239 239
Lines 76594 76576 -18
Branches 76594 76576 -18
==========================================
- Hits 59925 59888 -37
- Misses 13614 13624 +10
- Partials 3055 3064 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. Optionally, I think you can make a few tests clearer by only setting the relevant properties.
Co-authored-by: Will Jones <[email protected]>
Co-authored-by: Will Jones <[email protected]>
12c2d9b
to
accb77c
Compare
I was trying to add a new option (load_blobs) to the scan exec and realized the args had gotten a little out of control. I refactored them into a struct. I've since abandoned my original idea (load_blobs) but wanted to see if others felt the refactor was worth keeping.