Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable write variable width data in 2.1 #3090

Merged
merged 12 commits into from
Nov 5, 2024

Conversation

broccoliSpicy
Copy link
Contributor

@broccoliSpicy broccoliSpicy commented Nov 5, 2024

This PR adds a Compute_Stat trait to DataBlock, to separate the statistics computation and statistics inquiry.

This PR also modifies do_flush and encode_miniblock in PrimitiveStructuralEncoder to enable write variable width data in 2.1(PrimitiveStructuralEncoder)

@github-actions github-actions bot added the enhancement New feature or request label Nov 5, 2024
@broccoliSpicy broccoliSpicy changed the title feat: enable Variable width data in 2.1 feat: enable write variable width data in 2.1 Nov 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.55914% with 25 lines in your changes missing coverage. Please review.

Project coverage is 77.16%. Comparing base (b7663fb) to head (f987ee7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance-encoding/src/statistics.rs 84.13% 22 Missing and 1 partial ⚠️
.../lance-encoding/src/encodings/logical/primitive.rs 94.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3090      +/-   ##
==========================================
- Coverage   77.34%   77.16%   -0.18%     
==========================================
  Files         240      240              
  Lines       79432    79732     +300     
  Branches    79432    79732     +300     
==========================================
+ Hits        61433    61522      +89     
- Misses      14830    15034     +204     
- Partials     3169     3176       +7     
Flag Coverage Δ
unittests 77.16% <86.55%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move forwards. I've created #3094 to make sure we come back at some point and decide if we want stats to be lazy or not.

@broccoliSpicy broccoliSpicy merged commit 98f642c into lancedb:main Nov 5, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants