-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable write variable width data in 2.1 #3090
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3090 +/- ##
==========================================
- Coverage 77.34% 77.16% -0.18%
==========================================
Files 240 240
Lines 79432 79732 +300
Branches 79432 79732 +300
==========================================
+ Hits 61433 61522 +89
- Misses 14830 15034 +204
- Partials 3169 3176 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move forwards. I've created #3094 to make sure we come back at some point and decide if we want stats to be lazy or not.
This PR adds a
Compute_Stat
trait to DataBlock, to separate the statistics computation and statistics inquiry.This PR also modifies
do_flush
andencode_miniblock
inPrimitiveStructuralEncoder
to enable write variable width data in 2.1(PrimitiveStructuralEncoder)