Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass terminal dimensions into container #42

Closed
wants to merge 1 commit into from

Conversation

AaronFeledy
Copy link
Member

@AaronFeledy AaronFeledy commented Jul 29, 2023

Resolves lando/lando#1847 by grabbing the current terminal dimensions and passing them in with the tooling command at run time via the LINES and COLUMNS env vars. The same fix is applied to legacy core at lando/core#50.

@netlify
Copy link

netlify bot commented Jul 29, 2023

Deploy Preview for lando-core-next failed. Why did it fail? →

Name Link
🔨 Latest commit b79b431
🔍 Latest deploy log https://app.netlify.com/sites/lando-core-next/deploys/64c4ce7f255c0f0008498f99

@AaronFeledy
Copy link
Member Author

@pirog I just patched things up here to get the feature working, but the fact that it's still in the legacy code is bothering me. Looks like the v4 patterns would move this functionality into the utils directory and move away from lodash. Any pointers? I could also do a bit more refactoring if you've got a greater vision for how terminal parameters or passing env vars should work in v4.

@pirog
Copy link
Member

pirog commented Aug 10, 2023

@AaronFeledy i think this is good however im not quite sure where this should live yet, i suspect ultimately in @lando/cli-next which we are currently prototying in https://github.com/lando/cli/blob/main/lib/cli-next.js

im not sure we want to add it into Lando 3 proper just because it feels like it could be a pretty big change. However i would support adding it somewhere in https://github.com/lando/cli/blob/main/lib/cli-next.js so that it is available downstream. eg if you use the Lando 4 runtime (which currently uses cli-next.js) you can get the terminal sizing from the cli object when constructing the tooling environment. does that make sense?

@AaronFeledy
Copy link
Member Author

Docker now manages this and Lando should not interfere. Closing in favor of lando/core#179

@AaronFeledy AaronFeledy deleted the pass-terminal-dimensions branch June 21, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible to change COLUMNS environment variable?
2 participants