Skip to content

Commit

Permalink
Re-enable pylint in info-only mode for all packages (googleapis#3519)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jon Wayne Parrott authored and landrito committed Aug 21, 2017
1 parent ef14f39 commit e0d70fa
Show file tree
Hide file tree
Showing 36 changed files with 588 additions and 55 deletions.
13 changes: 10 additions & 3 deletions bigquery/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,22 @@ def system_tests(session, python_version):

@nox.session
def lint(session):
"""Run flake8.
"""Run linters.
Returns a failure if flake8 finds linting errors or sufficiently
Returns a failure if the linters find linting errors or sufficiently
serious code quality issues.
"""
session.interpreter = 'python3.6'
session.install('flake8', *LOCAL_DEPS)
session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
session.install('.')
session.run('flake8', 'google/cloud/bigquery')
session.run(
'gcp-devrel-py-tools', 'run-pylint',
'--config', 'pylint.config.py',
'--library-filesets', 'google',
'--test-filesets', 'tests',
# Temporarily allow this to fail.
success_codes=range(0, 100))


@nox.session
Expand Down
25 changes: 25 additions & 0 deletions bigquery/pylint.config.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Copyright 2017 Google Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""This module is used to configure gcp-devrel-py-tools run-pylint."""

# Library configuration

# library_additions = {}
# library_replacements = {}

# Test configuration

# test_additions = copy.deepcopy(library_additions)
# test_replacements = copy.deepcopy(library_replacements)
13 changes: 10 additions & 3 deletions bigtable/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,22 @@ def system_tests(session, python_version):

@nox.session
def lint(session):
"""Run flake8.
"""Run linters.
Returns a failure if flake8 finds linting errors or sufficiently
Returns a failure if the linters find linting errors or sufficiently
serious code quality issues.
"""
session.interpreter = 'python3.6'
session.install('flake8', *LOCAL_DEPS)
session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
session.install('.')
session.run('flake8', 'google/cloud/bigtable')
session.run(
'gcp-devrel-py-tools', 'run-pylint',
'--config', 'pylint.config.py',
'--library-filesets', 'google',
'--test-filesets', 'tests',
# Temporarily allow this to fail.
success_codes=range(0, 100))


@nox.session
Expand Down
25 changes: 25 additions & 0 deletions bigtable/pylint.config.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Copyright 2017 Google Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""This module is used to configure gcp-devrel-py-tools run-pylint."""

# Library configuration

# library_additions = {}
# library_replacements = {}

# Test configuration

# test_additions = copy.deepcopy(library_additions)
# test_replacements = copy.deepcopy(library_replacements)
13 changes: 10 additions & 3 deletions datastore/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,15 +90,22 @@ def doctests(session):

@nox.session
def lint(session):
"""Run flake8.
"""Run linters.
Returns a failure if flake8 finds linting errors or sufficiently
Returns a failure if the linters find linting errors or sufficiently
serious code quality issues.
"""
session.interpreter = 'python3.6'
session.install('flake8', *LOCAL_DEPS)
session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
session.install('.')
session.run('flake8', 'google/cloud/datastore')
session.run(
'gcp-devrel-py-tools', 'run-pylint',
'--config', 'pylint.config.py',
'--library-filesets', 'google',
'--test-filesets', 'tests',
# Temporarily allow this to fail.
success_codes=range(0, 100))


@nox.session
Expand Down
25 changes: 25 additions & 0 deletions datastore/pylint.config.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Copyright 2017 Google Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""This module is used to configure gcp-devrel-py-tools run-pylint."""

# Library configuration

# library_additions = {}
# library_replacements = {}

# Test configuration

# test_additions = copy.deepcopy(library_additions)
# test_replacements = copy.deepcopy(library_replacements)
15 changes: 11 additions & 4 deletions dns/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,22 @@ def unit_tests(session, python_version):

@nox.session
def lint(session):
"""Run flake8.
"""Run linters.
Returns a failure if flake8 finds linting errors or sufficiently
Returns a failure if the linters find linting errors or sufficiently
serious code quality issues.
"""
session.interpreter = 'python3.6'
session.install('flake8', *LOCAL_DEPS)
session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
session.install('.')
session.run('flake8', 'google/cloud/dns')
session.run('flake8', 'google/cloud/datastore')
session.run(
'gcp-devrel-py-tools', 'run-pylint',
'--config', 'pylint.config.py',
'--library-filesets', 'google',
'--test-filesets', 'tests',
# Temporarily allow this to fail.
success_codes=range(0, 100))


@nox.session
Expand Down
25 changes: 25 additions & 0 deletions dns/pylint.config.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Copyright 2017 Google Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""This module is used to configure gcp-devrel-py-tools run-pylint."""

# Library configuration

# library_additions = {}
# library_replacements = {}

# Test configuration

# test_additions = copy.deepcopy(library_additions)
# test_replacements = copy.deepcopy(library_replacements)
13 changes: 10 additions & 3 deletions error_reporting/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,22 @@ def unit_tests(session, python_version):

@nox.session
def lint(session):
"""Run flake8.
"""Run linters.
Returns a failure if flake8 finds linting errors or sufficiently
Returns a failure if the linters find linting errors or sufficiently
serious code quality issues.
"""
session.interpreter = 'python3.6'
session.install('flake8', *LOCAL_DEPS)
session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
session.install('.')
session.run('flake8', 'google/cloud/error_reporting')
session.run(
'gcp-devrel-py-tools', 'run-pylint',
'--config', 'pylint.config.py',
'--library-filesets', 'google',
'--test-filesets', 'tests',
# Temporarily allow this to fail.
success_codes=range(0, 100))


@nox.session
Expand Down
25 changes: 25 additions & 0 deletions error_reporting/pylint.config.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Copyright 2017 Google Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""This module is used to configure gcp-devrel-py-tools run-pylint."""

# Library configuration

# library_additions = {}
# library_replacements = {}

# Test configuration

# test_additions = copy.deepcopy(library_additions)
# test_replacements = copy.deepcopy(library_replacements)
13 changes: 10 additions & 3 deletions language/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,22 @@ def system_tests(session, python_version):

@nox.session
def lint(session):
"""Run flake8.
"""Run linters.
Returns a failure if flake8 finds linting errors or sufficiently
Returns a failure if the linters find linting errors or sufficiently
serious code quality issues.
"""
session.interpreter = 'python3.6'
session.install('flake8', *LOCAL_DEPS)
session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
session.install('.')
session.run('flake8', 'google/cloud/language')
session.run(
'gcp-devrel-py-tools', 'run-pylint',
'--config', 'pylint.config.py',
'--library-filesets', 'google',
'--test-filesets', 'tests',
# Temporarily allow this to fail.
success_codes=range(0, 100))


@nox.session
Expand Down
25 changes: 25 additions & 0 deletions language/pylint.config.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Copyright 2017 Google Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""This module is used to configure gcp-devrel-py-tools run-pylint."""

# Library configuration

# library_additions = {}
# library_replacements = {}

# Test configuration

# test_additions = copy.deepcopy(library_additions)
# test_replacements = copy.deepcopy(library_replacements)
13 changes: 10 additions & 3 deletions logging/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,22 @@ def system_tests(session, python_version):

@nox.session
def lint(session):
"""Run flake8.
"""Run linters.
Returns a failure if flake8 finds linting errors or sufficiently
Returns a failure if the linters find linting errors or sufficiently
serious code quality issues.
"""
session.interpreter = 'python3.6'
session.install('flake8', *LOCAL_DEPS)
session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
session.install('.')
session.run('flake8', 'google/cloud/logging')
session.run(
'gcp-devrel-py-tools', 'run-pylint',
'--config', 'pylint.config.py',
'--library-filesets', 'google',
'--test-filesets', 'tests',
# Temporarily allow this to fail.
success_codes=range(0, 100))


@nox.session
Expand Down
25 changes: 25 additions & 0 deletions logging/pylint.config.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Copyright 2017 Google Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""This module is used to configure gcp-devrel-py-tools run-pylint."""

# Library configuration

# library_additions = {}
# library_replacements = {}

# Test configuration

# test_additions = copy.deepcopy(library_additions)
# test_replacements = copy.deepcopy(library_replacements)
13 changes: 10 additions & 3 deletions monitoring/nox.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,22 @@ def system_tests(session, python_version):

@nox.session
def lint(session):
"""Run flake8.
"""Run linters.
Returns a failure if flake8 finds linting errors or sufficiently
Returns a failure if the linters find linting errors or sufficiently
serious code quality issues.
"""
session.interpreter = 'python3.6'
session.install('flake8', *LOCAL_DEPS)
session.install('flake8', 'pylint', 'gcp-devrel-py-tools', *LOCAL_DEPS)
session.install('.')
session.run('flake8', 'google/cloud/monitoring')
session.run(
'gcp-devrel-py-tools', 'run-pylint',
'--config', 'pylint.config.py',
'--library-filesets', 'google',
'--test-filesets', 'tests',
# Temporarily allow this to fail.
success_codes=range(0, 100))


@nox.session
Expand Down
Loading

0 comments on commit e0d70fa

Please sign in to comment.