Skip to content

Commit

Permalink
Fix documentation for from_documents signature (#8482)
Browse files Browse the repository at this point in the history
Docs for from_documents() were outdated as seen in
#8457 .

fixes #8457 

<!-- Thank you for contributing to LangChain!

Replace this comment with:
  - Description: a description of the change, 
  - Issue: the issue # it fixes (if applicable),
  - Dependencies: any dependencies required for this change,
- Tag maintainer: for a quicker response, tag the relevant maintainer
(see below),
- Twitter handle: we announce bigger features on Twitter. If your PR
gets announced and you'd like a mention, we'll gladly shout you out!

Please make sure you're PR is passing linting and testing before
submitting. Run `make format`, `make lint` and `make test` to check this
locally.

If you're adding a new integration, please include:
1. a test for the integration, preferably unit tests that do not rely on
network access,
  2. an example notebook showing its use.

Maintainer responsibilities:
  - General / Misc / if you don't know who to tag: @baskaryan
  - DataLoaders / VectorStores / Retrievers: @rlancemartin, @eyurtsev
  - Models / Prompts: @hwchase17, @baskaryan
  - Memory: @hwchase17
  - Agents / Tools / Toolkits: @hinthornw
  - Tracing / Callbacks: @agola11
  - Async: @agola11

If no one reviews your PR within a few days, feel free to @-mention the
same people again.

See contribution guidelines for more information on how to write/run
tests, lint, etc:
https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md
 -->
  • Loading branch information
lud-hu authored Jul 30, 2023
1 parent 4923cf0 commit 08f5e6b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions docs/extras/integrations/vectorstores/qdrant.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@
"qdrant = Qdrant.from_documents(\n",
" docs,\n",
" embeddings,\n",
" url,\n",
" url=url,\n",
" prefer_grpc=True,\n",
" collection_name=\"my_documents\",\n",
")"
Expand Down Expand Up @@ -236,7 +236,7 @@
"qdrant = Qdrant.from_documents(\n",
" docs,\n",
" embeddings,\n",
" url,\n",
" url=url,\n",
" prefer_grpc=True,\n",
" api_key=api_key,\n",
" collection_name=\"my_documents\",\n",
Expand Down Expand Up @@ -270,7 +270,7 @@
"qdrant = Qdrant.from_documents(\n",
" docs,\n",
" embeddings,\n",
" url,\n",
" url=url,\n",
" prefer_grpc=True,\n",
" collection_name=\"my_documents\",\n",
" force_recreate=True,\n",
Expand Down

0 comments on commit 08f5e6b

Please sign in to comment.