Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_llm_chain_filter is flaky in libs/langchain #26273

Closed
5 tasks done
efriis opened this issue Sep 10, 2024 · 0 comments · Fixed by #26924
Closed
5 tasks done

test_llm_chain_filter is flaky in libs/langchain #26273

efriis opened this issue Sep 10, 2024 · 0 comments · Fixed by #26924
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature

Comments

@efriis
Copy link
Member

efriis commented Sep 10, 2024

Checked other resources

  • I added a very descriptive title to this issue.
  • I searched the LangChain documentation with the integrated search.
  • I used the GitHub search to find a similar question and didn't find it.
  • I am sure that this is a bug in LangChain rather than my code.
  • The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code

https://github.com/langchain-ai/langchain/actions/runs/10798432256/job/29951972859?pr=26270

Error Message and Stack Trace (if applicable)

  At index 1 diff: Document(metadata={'c': 3}, page_content='The moon is round.') != Document(metadata={'b': 2}, page_content='Candlepin bowling balls are smaller.')
  Full diff:
    [
     Document(metadata={'a': 1}, page_content='Candlepin bowling is popular in New England.'),
  -  Document(metadata={'b': 2}, page_content='Candlepin bowling balls are smaller.'),
  +  Document(metadata={'c': 3}, page_content='The moon is round.'),
    ]```

### Description

This unit test mostly succeeds, sometimes documents seem to come back in wrong order

Likely a bug in the document compressor

### System Info

CI
@dosubot dosubot bot added the 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature label Sep 10, 2024
@efriis efriis closed this as completed in ab4dab9 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant