Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix batch race condition in FakeListChatModel #26924

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

efriis
Copy link
Member

@efriis efriis commented Sep 27, 2024

fixed #26273

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 11:11pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: core Related to langchain-core 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Sep 27, 2024
@efriis efriis enabled auto-merge (squash) September 27, 2024 00:29
@eyurtsev
Copy link
Collaborator

@efriis we probably have this across most of the fake models that take in a list of inputs then

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Oct 3, 2024
@efriis efriis enabled auto-merge (squash) October 3, 2024 23:11
@efriis efriis merged commit ab4dab9 into master Oct 3, 2024
85 checks passed
@efriis efriis deleted the erick/fake-list-chat-model-batch branch October 3, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: core Related to langchain-core lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

test_llm_chain_filter is flaky in libs/langchain
3 participants