Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: Fix pgvector deprecated filter clause usage with OR and AND conditions #20446

Merged
merged 2 commits into from
Apr 16, 2024
Merged

community: Fix pgvector deprecated filter clause usage with OR and AND conditions #20446

merged 2 commits into from
Apr 16, 2024

Conversation

MartinGotelli
Copy link
Contributor

Description: Support filter by OR and AND for deprecated PGVector version
Issue: #20445
Dependencies: N/A
Twitter handle: @martinferenaz

@vercel Vercel
Copy link

vercel bot commented Apr 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Apr 14, 2024 10:35pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🔌: postgres Related to postgres integrations 🤖:improvement Medium size change to existing code to handle new use-cases labels Apr 14, 2024
@MartinGotelli MartinGotelli changed the title Pgvector deprecated or and conditions community: Fix pgvector deprecated filter clause usage with OR and AND conditions Apr 14, 2024
@yuntongzhang yuntongzhang mentioned this pull request Apr 15, 2024
Merged
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Apr 16, 2024
@eyurtsev
Copy link
Collaborator

Thanks! Going to merge the fix, though I recommend to folks to move to langchain_postgres which has a more efficient implementation (that has other issues resolved with it as well)

@eyurtsev eyurtsev enabled auto-merge (squash) April 16, 2024 14:05
@eyurtsev eyurtsev merged commit b48add4 into langchain-ai:master Apr 16, 2024
60 checks passed
@Alonoparag Alonoparag mentioned this pull request Apr 24, 2024
Closed
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
@MartinGotelli @hinthornw
community[patch]: Fix pgvector deprecated filter clause usage with OR…
aba9706 
… and AND conditions (#20446)

**Description**: Support filter by OR and AND for deprecated PGVector
version
**Issue**: #20445 
**Dependencies**: N/A
**Twitter** handle: @martinferenaz
@MartinGotelli MartinGotelli deleted the pgvector_deprecated_or_and_conditions branch May 5, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

Assignees
No one assigned
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. 🔌: postgres Related to postgres integrations size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinGotelli @eyurtsev