openai: embeddings: supported chunk_size when check_embedding_ctx_length is disabled #23767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:S
adubovik
force-pushed
the
master
branch
2 times, most recently
from
215c34e
to
03f6842
Compare
|
@efriis is there something I could do to impove the PR? Thanks |
|
reassigning to @baskaryan who recently refactored this! |
|
Hi, @baskaryan! Do you have any suggestions? |
dosubot
bot
added
size:M
efriis
approved these changes
Sep 20, 2024
dosubot
bot
added
the
lgtm
sfc-gh-nmoiseyev
pushed a commit
to sfc-gh-nmoiseyev/langchain
that referenced
this pull request
Sep 21, 2024
…gth is disabled (langchain-ai#23767) Chunking of the input array controlled by `self.chunk_size` is being ignored when `self.check_embedding_ctx_length` is disabled. Effectively, the chunk size is assumed to be equal 1 in such a case. This is suprising. The PR takes into account `self.chunk_size` passed by the user. --------- Co-authored-by: Erick Friis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chunking of the input array controlled by
self.chunk_sizeis being ignored whenself.check_embedding_ctx_lengthis disabled. Effectively, the chunk size is assumed to be equal 1 in such a case. This is suprising.The PR takes into account
self.chunk_sizepassed by the user.