-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: Add Naver chat model & embeddings #25162
community: Add Naver chat model & embeddings #25162
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
d2f5b2a
to
0797c7e
Compare
1992ee6
to
bdcb421
Compare
Hello @efriis, We've been preparing for this community package and waiting for review (following up our prior communication on early August via email), and I think we are all ready to go! Could you check this PR? |
253b9ff
to
a575045
Compare
Thanks for the ping! Could you get CI passing? |
5548cc3
to
79edab0
Compare
Thanks @efriis , seems we referred to some outdated docs, got failed linting test. |
5959105
to
9898831
Compare
Hi @vbarda , just found out that assignee to this pr has changed to you. Looking forward to cooperate! It seems there was the only lint fail due to the updates in poetry.lock file for the recent test and now fixed. |
@hyper-clova hey folks -- the change looks good overall! i added a couple of small comments / suggestions. i think we're very close to merging this! |
Reopened as a personal repo outside the organization.
Description
Twitter handle: None. (if needed, contact with [email protected])
you can check our previous discussion below:
I would like to keep it as is, unless it is essential to unify the package name.
(ClovaX is a branding for the model, and I plan to add other models and components. They need to be managed as separate classes.)
There are 3 models that are being serviced by embedding, and all are supported in the current PR. In addition, all the functionality of CLOVA Studio that serves actual models, such as distinguishing between test apps and service apps, is supported. The existing PR does not support this content because it is hard-coded.