Feature/update hunyuan #25779
Merged
Feature/update hunyuan #25779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the default values of Temperature and TopP - Add SystemMessage
…ng, and initialize the response id field value to request_id
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
ccurme
reviewed
Aug 27, 2024
| @@ -112,10 +117,10 @@ def lc_serializable(self) -> bool: | |||
| """What sampling temperature to use.""" | |||
| top_p: float = 1.0 | |||
| """What probability mass to use.""" | |||
| model: str = "hunyuan-lite" | |||
| model: str = "hunyuan-pro" | |||
There was a problem hiding this comment.
this will quietly change the model type for anyone relying on the default model, here. Suggest keeping unchanged.
There was a problem hiding this comment.
ok，Restore Default Model
| generations.append(ChatGeneration(message=message)) | ||
|
|
||
| token_usage = response["Usage"] | ||
| llm_output = {"token_usage": token_usage} | ||
| llm_output = {"token_usage": response.get("Usage", "")} |
There was a problem hiding this comment.
is empty string the correct type for token usage?
There was a problem hiding this comment.
ok，Changes have been rolled back
xander-art
force-pushed
the
feature/update_hunyuan
branch
from
7323c4a
to
6b2b25c
Compare
ccurme
approved these changes
Aug 28, 2024
dosubot
bot
added
the
lgtm
auto-merge was automatically disabled
August 29, 2024 07:21
Head branch was pushed to by a user without write access
ccurme
approved these changes
Aug 29, 2024
auto-merge was automatically disabled
August 30, 2024 06:12
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
- Add system templates and user templates in integration testing
- initialize the response id field value to request_id
- Adjust the default model to hunyuan-pro
- Remove the default values of Temperature and TopP
- Add SystemMessage
all the integration tests have passed.
1、Execute integration tests for the first time
2、Run the integration test a second time
Issue: None
Dependencies: None
Twitter handle: None