-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community: Updated Firecrawl Document Loader to v1 #26548
Community: Updated Firecrawl Document Loader to v1 #26548
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey there! This is a breaking change. Could you keep around (but deprecate use of) the old input parameters?
I installed Firecrawl using "pipenv install firecrawl-py" and pipfile.lock shows the version": "==1.2.4" AttributeError: 'str' object has no attribute 'get' |
This is probably because this hasn't been merged yet! @rafaelsideguide is there anything else we need to do to get this through? |
Hey @calebpeffer, I'm currently updating the PR to ensure it's not a breaking change, as requested by @efriis. I'll be pushing the updates in a few hours. |
Hey @efriis! I updated the PR with the requested changes. Could you take a look? Thank you! |
def __init__( | ||
self, | ||
url: str, | ||
*, | ||
api_key: Optional[str] = None, | ||
api_url: Optional[str] = None, | ||
mode: Literal["crawl", "scrape"] = "crawl", | ||
mode: Literal["crawl", "scrape", "map"] = "crawl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just confirming this will be a breaking change to anyone passing api_url
. It's ok with me if it's ok on the firecrawl side!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that's not good. I just reverted that. @efriis Thank you!
if not url: | ||
raise ValueError("Url must be provided") | ||
|
||
api_key = api_key or get_from_env("api_key", "FIREWALL_API_KEY") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix FIREWALL_API_KEY to FIRECRAWL_API_KEY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
raise ValueError("Url must be provided") | ||
|
||
api_key = api_key or get_from_env("api_key", "FIREWALL_API_KEY") | ||
self.firecrawl = FirecrawlApp(api_key=api_key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-add api_url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
@rafaelsideguide can you fix those please? Thank you! |
@nickscamara done |
Sweet thanks! I think this is all good to merge! |
Hi! Any news with this ? :) |
Hey @efriis, could you run the GitHub workflows when you have a chance? I’d like to check if there are any issues. Thank you! |
This PR updates the Firecrawl Document Loader to use the recently released V1 API of Firecrawl.
Key Updates:
Firecrawl V1 Integration: Updated the document loader to leverage the new Firecrawl V1 API for improved performance, reliability, and developer experience.
Map Functionality Added: Introduced the map mode for more flexible document loading options.
These updates enhance the integration and provide access to the latest features of Firecrawl.