Avoid copying runs #26689
Avoid copying runs #26689
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
size:L
hinthornw
force-pushed
the
wfh/happyfamily
branch
from
f99d417
to
ee5f1c1
Compare
dosubot
bot
added
community
| def _start_trace(self, run: Run) -> None: | ||
| super()._start_trace(run) | ||
| if run._client is None: | ||
| run._client = self.client |
There was a problem hiding this comment.
This is so that if you were defining the client solely via a LangChainTracer we will hand off that client to the nested run tree
There was a problem hiding this comment.
any situations when one might create two tracers with different clients and pass them as callbacks?
There was a problem hiding this comment.
Hmm.
This would still work in the case where it's all langchain code then.
This would not work for implicit propagation handoff to traceable (since traceable doesn't let you set multiple parents at a given time)
In either case I think that would be undesirable / haven't heard of anyone doing that before
There was a problem hiding this comment.
I assume no easy way to catch that as an issue to raise an error?
There was a problem hiding this comment.
hmm I kinda would prefer if we still traced something / didn't raise an error that could potentially interrupt their execution flow? It's kinda hard to catch correctly
| global _CLIENT | ||
| if _CLIENT is not None and _CLIENT.tracing_queue is not None: | ||
| _CLIENT.tracing_queue.join() | ||
| if rt._CLIENT is not None and rt._CLIENT.tracing_queue is not None: |
| def _start_trace(self, run: Run) -> None: | ||
| super()._start_trace(run) | ||
| if run._client is None: | ||
| run._client = self.client |
There was a problem hiding this comment.
any situations when one might create two tracers with different clients and pass them as callbacks?
dosubot
bot
added
the
lgtm
Also, re-unify run trees. Use a single shared client.
Also, re-unify run trees. Use a single shared client. Etc.