community: Handle empty PR body in get_pull_request in Github utility #26739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:XS
LilitGabrielyan
approved these changes
Sep 21, 2024
baskaryan
approved these changes
Sep 22, 2024
dosubot
bot
added
the
lgtm
Sheepsta300
pushed a commit
to Sheepsta300/langchain
that referenced
this pull request
Oct 1, 2024
…utility (langchain-ai#26739) **Description:** When PR body is empty `get_pull_request` method fails with bellow exception. **Issue:** ``` TypeError('expected string or buffer')Traceback (most recent call last): File ".../.venv/lib/python3.9/site-packages/langchain_core/tools/base.py", line 661, in run response = context.run(self._run, *tool_args, **tool_kwargs) File ".../.venv/lib/python3.9/site-packages/langchain_community/tools/github/tool.py", line 52, in _run return self.api_wrapper.run(self.mode, query) File ".../.venv/lib/python3.9/site-packages/langchain_community/utilities/github.py", line 816, in run return json.dumps(self.get_pull_request(int(query))) File ".../.venv/lib/python3.9/site-packages/langchain_community/utilities/github.py", line 495, in get_pull_request add_to_dict(response_dict, "body", pull.body) File ".../.venv/lib/python3.9/site-packages/langchain_community/utilities/github.py", line 487, in add_to_dict tokens = get_tokens(value) File ".../.venv/lib/python3.9/site-packages/langchain_community/utilities/github.py", line 483, in get_tokens return len(tiktoken.get_encoding("cl100k_base").encode(text)) File "....venv/lib/python3.9/site-packages/tiktoken/core.py", line 116, in encode if match := _special_token_regex(disallowed_special).search(text): TypeError: expected string or buffer ``` **Twitter:** __gorros__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When PR body is empty
get_pull_requestmethod fails with bellow exception.Issue:
Twitter: gorros