Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance BM25SparseEmbedding initialization #26769

Closed
wants to merge 3 commits into from

Conversation

FouadLbakali
Copy link

  • PR title: "Enhance BM25SparseEmbedding initialization"

  • PR message:

    • Description: This update enhances the BM25SparseEmbedding class by allowing the initialization to optionally load a model from a specified path, in addition to fitting it with a provided corpus. This makes the embedding model more flexible for different use cases.
    • Issue: Not applicable

@efriis efriis added the partner label Sep 23, 2024
@efriis efriis self-assigned this Sep 23, 2024
Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 3:01pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: embeddings Related to text embedding models module labels Sep 23, 2024
Copy link
Collaborator

@eyurtsev eyurtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few different bugs in this PR, left comments

libs/partners/milvus/langchain_milvus/utils/sparse.py Outdated Show resolved Hide resolved
libs/partners/milvus/langchain_milvus/utils/sparse.py Outdated Show resolved Hide resolved
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 25, 2024
@efriis
Copy link
Member

efriis commented Nov 7, 2024

You can find the integration package you would want to edit here: https://github.com/langchain-ai/langchain-milvus

sorry for the inconvenience!

@efriis efriis closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: embeddings Related to text embedding models module partner size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants