langchain_milvus: Add add_embeddings method for Milvus vector store

[Mateusz-Switala]

Thank you for contributing to LangChain!

• PR title: "package: description"

  • Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes.
  • Example: "community: add foobar LLM"

• PR message:

  • Description: The aim of these changes is to add method add_embeddings to the Milvus vector store. This method would allow users to add data to vector store in cases where they already have generated embeddings for their text data.

fyi @LukaszCmielowski

• Add tests and docs:

  1. Added test that uses add_embeddings method

• Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:

• Make sure optional dependencies are imported within a function.
• Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
• Most PRs should not touch more than one package.
• Changes should be backwards compatible.
• If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
langchain	⬜️ Ignored (Inspect)	Visit Preview		Sep 23, 2024 4:41pm

[eyurtsev]

Should probably be

Suggested change

	text_embeddings: Iterable[Tuple[str, List[float]]],
	embeddings: Sequence[Tuple[str, List[float]]],

[eyurtsev]

This is just a drive by review. I also don't know if it makes more sense to add embeddings as an optional argument to add_texts to avoid proliferation of entry points (we should see what's usually done for other vectorstores).