Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update neo4j vector procedures #26775

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tomasonjo
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 9:13pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. community Related to langchain-community Ɑ: vector store Related to vector store module labels Sep 23, 2024
"$embedding_node_property,"
"toInteger($embedding_dimension),"
"$similarity_metric )"
f"CREATE VECTOR INDEX {self.index_name} "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add IF NOT EXISTS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deliberately didnt add it as I want an error here if it already exists as otherwise there could be sth wrong upstream and we wouldnt know

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@jexp
Copy link
Contributor

jexp commented Sep 23, 2024

should we do for rel-index too?

@tomasonjo
Copy link
Contributor Author

No, we don't support importing data for relationship vector index, so we don't need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community size:S This PR changes 10-29 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

2 participants