Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Update UC toolkit documentation to use LangGraph APIs #26778

Merged

Conversation

smurching
Copy link
Contributor

  • Description: Update UC toolkit documentation to show an example of using recommended LangGraph agent APIs before the existing LangChain AgentExecutor example. Tested by manually running the updated example notebook
  • Dependencies: No new dependencies

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 23, 2024
Signed-off-by: Sid Murching <[email protected]>
Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 2:47am

@dosubot dosubot bot added community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Sep 23, 2024
@smurching smurching changed the title community: Update UC toolkit documentation to use LangGraph APIs community: Update UC toolkit documentation to use LangGraph APIs Sep 23, 2024
Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
@smurching smurching force-pushed the smurching/update-uc-toolkit-docs branch from a48d8c5 to fe31451 Compare September 26, 2024 16:38
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 26, 2024
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's possible something is funky in the formatting of this notebook because github is refusing to render the diff (also possible github has more bugs in notebook rendering 🫠)

If it passes vercel build that's good with me

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Sep 30, 2024
@efriis
Copy link
Member

efriis commented Sep 30, 2024

actually yeah needs some formatting fixes

Copy link
Contributor

@B-Step62 B-Step62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just a few minor nits

Comment on lines +39 to +46
"outputs": [
{
"name": "stdout",
"output_type": "stream",
"text": [
"Note: you may need to restart the kernel to use updated packages.\n"
]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we remove this output?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just kept it in because it's what's produced when running the notebook, seems ok to have it show up

"source": [
"%pip install --upgrade --quiet databricks-sdk langchain-community mlflow"
"%pip install --upgrade --quiet databricks-sdk langchain-community langgraph mlflow"
]
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we the update import for ChatDatabricks to langchain-databricks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, done!

Signed-off-by: Sid Murching <[email protected]>
@smurching
Copy link
Contributor Author

Thanks all - reran and pushed updated notebook output with python 3.11 - looks like both the Vercel build and the official live docs have the same formatting weirdness for the final agent output, I figure that's ok:
image

Otherwise the notebook content seems to render fine :)

@efriis efriis enabled auto-merge (squash) November 7, 2024 02:39
@efriis efriis merged commit cfff2a0 into langchain-ai:master Nov 7, 2024
13 checks passed
yanomaly pushed a commit to yanomaly/langchain that referenced this pull request Nov 8, 2024
…gchain-ai#26778)

- **Description:** Update UC toolkit documentation to show an example of
using recommended LangGraph agent APIs before the existing LangChain
AgentExecutor example. Tested by manually running the updated example
notebook
- **Dependencies:** No new dependencies

---------

Signed-off-by: Sid Murching <[email protected]>
Co-authored-by: Erick Friis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants