-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: Update UC toolkit documentation to use LangGraph APIs #26778
community: Update UC toolkit documentation to use LangGraph APIs #26778
Conversation
smurching
commented
Sep 23, 2024
- Description: Update UC toolkit documentation to show an example of using recommended LangGraph agent APIs before the existing LangChain AgentExecutor example. Tested by manually running the updated example notebook
- Dependencies: No new dependencies
…ic error Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
Signed-off-by: Sid Murching <[email protected]>
a48d8c5
to
fe31451
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's possible something is funky in the formatting of this notebook because github is refusing to render the diff (also possible github has more bugs in notebook rendering 🫠)
If it passes vercel build that's good with me
actually yeah needs some formatting fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just a few minor nits
"outputs": [ | ||
{ | ||
"name": "stdout", | ||
"output_type": "stream", | ||
"text": [ | ||
"Note: you may need to restart the kernel to use updated packages.\n" | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can we remove this output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just kept it in because it's what's produced when running the notebook, seems ok to have it show up
"source": [ | ||
"%pip install --upgrade --quiet databricks-sdk langchain-community mlflow" | ||
"%pip install --upgrade --quiet databricks-sdk langchain-community langgraph mlflow" | ||
] | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can we the update import for ChatDatabricks
to langchain-databricks
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, done!
Signed-off-by: Sid Murching <[email protected]>
…ng/langchain into smurching/update-uc-toolkit-docs
Thanks all - reran and pushed updated notebook output with python 3.11 - looks like both the Vercel build and the official live docs have the same formatting weirdness for the final agent output, I figure that's ok: Otherwise the notebook content seems to render fine :) |
…gchain-ai#26778) - **Description:** Update UC toolkit documentation to show an example of using recommended LangGraph agent APIs before the existing LangChain AgentExecutor example. Tested by manually running the updated example notebook - **Dependencies:** No new dependencies --------- Signed-off-by: Sid Murching <[email protected]> Co-authored-by: Erick Friis <[email protected]>