core: Add ruff rules for comprehensions (C4) #26829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
eyurtsev
reviewed
Sep 24, 2024
| @@ -108,7 +108,7 @@ def get_format_instructions(self) -> str: | |||
| return "Return a JSON object." | |||
| else: | |||
| # Copy schema to avoid altering original Pydantic schema. | |||
| schema = {k: v for k, v in self._get_schema(self.pydantic_object).items()} | |||
| schema = dict(self._get_schema(self.pydantic_object).items()) | |||
There was a problem hiding this comment.
hmm why is this not .copy()
(no need to change in this PR -- since the PR should involve no functional changes)
eyurtsev
approved these changes
Sep 24, 2024
dosubot
bot
added
the
lgtm
|
cc @efriis if you want to take another look prior to merging. I think this looks good, code is cleaner and likely at some point will result in a tiny code speed up due to short-circuiting where it wasn't before or due to elimination of redundant operations |
efriis
approved these changes
Sep 24, 2024
cbornet
changed the title
cbornet
force-pushed
the
ruff-rules-c4
branch
from
0874e19
to
5231692
Compare
Sheepsta300
pushed a commit
to Sheepsta300/langchain
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.