Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[patch]: fix init of RunnableAssign #26903

Merged
merged 3 commits into from
Oct 1, 2024
Merged

core[patch]: fix init of RunnableAssign #26903

merged 3 commits into from
Oct 1, 2024

Conversation

ccurme
Copy link
Collaborator

@ccurme ccurme commented Sep 26, 2024

Example in API ref currently raises ValidationError.

Resolves #26862

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Sep 26, 2024 3:58pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Ɑ: core Related to langchain-core 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Sep 26, 2024
@@ -389,7 +389,7 @@ def add_ten(x: Dict[str, int]) -> Dict[str, int]:
# returns {'input': 5, 'add_step': {'added': 15}}
"""

mapper: RunnableParallel[dict[str, Any]]
mapper: RunnableParallel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was that type annotation incorrect

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Sep 26, 2024
@ccurme ccurme merged commit 9d10151 into master Oct 1, 2024
85 checks passed
@ccurme ccurme deleted the cc/fix_assign_init branch October 1, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: core Related to langchain-core lgtm PR looks good. Use to confirm that a PR is ready for merging. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

RunnableAssign instantiation raises a pydantic validation error
2 participants