Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

huggingface[patch]: hide client field in HuggingFaceEmbeddings #27522

Merged
merged 2 commits into from
Oct 21, 2024
Merged

huggingface[patch]: hide client field in HuggingFaceEmbeddings #27522

merged 2 commits into from
Oct 21, 2024

Conversation

vbarda
Copy link
Contributor

@vbarda vbarda commented Oct 21, 2024

No description provided.

@vbarda vbarda requested a review from Jofthomas October 21, 2024 20:27
@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 8:48pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: embeddings Related to text embedding models module labels Oct 21, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Oct 21, 2024
@vbarda vbarda mentioned this pull request Oct 21, 2024
Closed
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 21, 2024
@vbarda vbarda merged commit 0640cbf into master Oct 21, 2024
19 checks passed
@vbarda vbarda deleted the vb/hide-client-field branch October 21, 2024 21:37
ccurme pushed a commit that referenced this pull request Oct 22, 2024
@vbarda @ccurme
huggingface[patch]: hide client field in HuggingFaceEmbeddings (#27522)
a376906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

@Jofthomas Jofthomas Awaiting requested review from Jofthomas

Assignees
No one assigned
Labels
Ɑ: embeddings Related to text embedding models module lgtm PR looks good. Use to confirm that a PR is ready for merging. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbarda @efriis