support connect milvus with token, fix auto id #2345
Conversation
Signed-off-by: nameczz <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:improvement
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
| @@ -632,7 +632,7 @@ | |||
| "@typescript-eslint/parser": "^5.58.0", | |||
There was a problem hiding this comment.
Great work on the PR! I've noticed a change in the "@zilliz/milvus2-sdk-node" dependency version, which seems to be a hard dependency change. This comment is to flag the change for maintainers to review and ensure it aligns with the project's requirements.
There was a problem hiding this comment.
I only update package.json in this pr, not sure about yarn.lock
langchain/src/vectorstores/milvus.ts
Outdated
| @@ -116,10 +119,26 @@ export class Milvus extends VectorStore { | |||
There was a problem hiding this comment.
This comment is flagging the change in the PR for maintainers to review as it accesses an environment variable indirectly through the getEnvironmentVariable function.
| @@ -421,7 +440,7 @@ export class Milvus extends VectorStore { | |||
| if (field.is_primary_key) { | |||
| this.primaryField = field.name; | |||
| } | |||
| const dtype = DataTypeMap[field.data_type.toLowerCase()]; | |||
| const dtype = DataTypeMap[field.data_type]; | |||
There was a problem hiding this comment.
In new sdk, data_type is keyof typeof DataType. So we don't need to lowerCase here, otherwise ts will throw error.
…update-milvus-with-new-sdk
|
Looks good! Appreciate the backwards compatibility shim! |
|
Thank you! |
Milvus node sdk support connect with token after v2.2.11 .
User need to use token if want to connect ZILLIZ cloud serverless cluster.
Also i find the hard code auto id = true in LangChain, so i optimized it.
Please help review this pr , thanks.