[Feature] Redis embedding store spring boot starter #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langchain4j
reviewed
Mar 14, 2024
There was a problem hiding this comment.
@Martin7-1 thank you a lot and so sorry for the late review, somehow I overlooked PRs in this repository :(
...rc/main/java/dev/langchain4j/store/embedding/redis/spring/RedisEmbeddingStoreProperties.java
Outdated
Show resolved
Hide resolved
...ava/dev/langchain4j/store/embedding/redis/spring/RedisEmbeddingStoreAutoConfigurationIT.java
Outdated
Show resolved
Hide resolved
...ava/dev/langchain4j/store/embedding/redis/spring/RedisEmbeddingStoreAutoConfigurationIT.java
Outdated
Show resolved
Hide resolved
| "langchain4j.redis.metadataFieldsName=test-key" | ||
| ) | ||
| .run(context -> { | ||
| EmbeddingStore<TextSegment> embeddingStore = context.getBean(RedisEmbeddingStore.class); |
There was a problem hiding this comment.
I would also add a check that context.getBean(EmbeddingStore.class) returns RedisEmbeddingStore
There was a problem hiding this comment.
The next line of code check it by assertThat(embeddingStore).isInstanceOf(RedisEmbeddingStore.class).
langchain4j
reviewed
Mar 14, 2024
added 3 commits
March 16, 2024 15:13
|
@langchain4j Hi! I've been done it with adding default dimension by |
Martin7-1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I add
langchian4j-redis-spring-boot-starterimplementation. Test run correct in my local environment.btw, I'll add spring boot starters to the other vector stores in a few days. Waiting for your code reviews!