Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: outputs_map parameter namings #3886

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

jordanrfrazier
Copy link
Collaborator

Couple issues were resulting around pulling the correct outputs due to small naming issue.

Ideally, we'll move to an enumeration rather than string-based so we can avoid these errors in the future.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Sep 23, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 23, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3886.dmtpw4p5recq1.amplifyapp.com

Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 23, 2024
@jordanrfrazier jordanrfrazier merged commit ed53fcd into main Sep 24, 2024
43 of 45 checks passed
@jordanrfrazier jordanrfrazier deleted the fix-outputs-mapping-var branch September 24, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants