Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Server is busy (#3878) #3895

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Server is busy (#3878) #3895

wants to merge 1 commit into from

Conversation

9n
Copy link

@9n 9n commented Sep 24, 2024

_build_vertex is async, so we should make it sync by asyncio.run before passing it to asyncio.to_thread

asyncio.create_task(asyncio.to_thread(asyncio.run, _build_vertex(vertex_id, graph, event_manager)))

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working python Pull requests that update Python code labels Sep 24, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 24, 2024
@aws-amplify-sa-east-1 AWS Amplify (sa-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3895.dmtpw4p5recq1.amplifyapp.com

ogabrielluiz
ogabrielluiz approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @9n

Good catch! We were having problems with this and I think this is the fix.

Thank you.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@9n @ogabrielluiz