-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adding info to Agent and related components #4495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwinjosechittilappilly
requested review from
rodrigosnader and
ogabrielluiz
November 11, 2024 15:34
CodSpeed Performance ReportMerging #4495 will degrade performances by 24.95%Comparing Summary
Benchmarks breakdown
|
ogabrielluiz
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the info we want are directed towards newer Users so try to be almost ELI5 level
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
enhancement
New feature or request
labels
Nov 11, 2024
ogabrielluiz
requested changes
Nov 11, 2024
edwinjosechittilappilly
force-pushed
the
fix-agent-descriptions
branch
from
November 12, 2024 02:03
e1bb583
to
6b49823
Compare
ogabrielluiz
approved these changes
Nov 12, 2024
update to Open AI model info
made info of LLM much simpler
ogabrielluiz
force-pushed
the
fix-agent-descriptions
branch
from
November 12, 2024 02:54
52abcaf
to
61bd280
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
agent.py
andtool_calling.py
files to add informative descriptions to various input fields. These changes aim to improve the clarity of the agent components by providing additional context for each input.Enhancements to input field descriptions:
src/backend/base/langflow/base/agents/agent.py
: Addedinfo
attributes toBoolInput
,IntInput
, andMultilineInput
fields in theLCAgentComponent
andLCToolsAgentComponent
classes to describe their purposes. [1] [2]src/backend/base/langflow/components/agents/agent.py
: Addedinfo
attributes toDropdownInput
andMultilineInput
fields in theAgentComponent
class to provide descriptions for the language model provider and system prompt. [1] [2]src/backend/base/langflow/components/agents/tool_calling.py
: Addedinfo
attributes toHandleInput
andDataInput
fields in theToolCallingAgentComponent
class to describe the language model provider and chat history storage.