Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update step duration display and logic #4506

Merged
merged 8 commits into from
Nov 12, 2024
Merged

fix: update step duration display and logic #4506

merged 8 commits into from
Nov 12, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request adds a new durationStore for managing chat durations and intervals. It updates the duration display logic to use the store, allowing for more efficient management of durations. The changes include adding a chatId prop to the ContentBlockDisplay and ContentDisplay components, updating the DurationDisplay component to use the duration store, and introducing a new useDurationStore hook for managing durations and intervals.

autofix-ci bot and others added 4 commits November 11, 2024 20:22
Improve accuracy of duration measurement in event handlers by centralizing the calculation method. This ensures consistent timing across different events and enhances the reliability of event processing.
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #4506 will not alter performance

Comparing fixDuration (3d1a24b) with main (84dd031)

Summary

✅ 15 untouched benchmarks

Enhance the duration calculation by clearly handling both integer and float timestamps. This ensures accurate duration tracking and simplifies the code structure, improving maintainability and readability.
@ogabrielluiz ogabrielluiz changed the title fix: fix duration bugs in agent playground fix: update step duration display and logic Nov 11, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 11, 2024
@anovazzi1 anovazzi1 marked this pull request as ready for review November 12, 2024 13:25
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 12, 2024
Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@Cristhianzl Cristhianzl merged commit f34d57a into main Nov 12, 2024
30 checks passed
@Cristhianzl Cristhianzl deleted the fixDuration branch November 12, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants