-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add NestedDictInput filter and non-vector search for AstraVectorStoreComponent #4564
Merged
erichare
merged 5 commits into
langflow-ai:main
from
mieslep:phil/astra-metadata-component
Nov 14, 2024
Merged
feat: add NestedDictInput filter and non-vector search for AstraVectorStoreComponent #4564
erichare
merged 5 commits into
langflow-ai:main
from
mieslep:phil/astra-metadata-component
Nov 14, 2024
+63
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Nov 13, 2024
CodSpeed Performance ReportMerging #4564 will degrade performances by 38.01%Comparing Summary
Benchmarks breakdown
|
ogabrielluiz
changed the title
NestedDictInput filter and non-vector search for AstraVectorStoreComp…
feat: addNestedDictInput filter and non-vector search for AstraVectorStoreComponent
Nov 13, 2024
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Nov 13, 2024
ogabrielluiz
changed the title
feat: addNestedDictInput filter and non-vector search for AstraVectorStoreComponent
feat: add NestedDictInput filter and non-vector search for AstraVectorStoreComponent
Nov 13, 2024
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Nov 13, 2024
erichare
reviewed
Nov 14, 2024
erichare
approved these changes
Nov 14, 2024
erichare
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small param issue (possibly)
erichare
approved these changes
Nov 14, 2024
ogabrielluiz
force-pushed
the
phil/astra-metadata-component
branch
from
November 14, 2024 15:57
530e1d9
to
2f75259
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and refactorings to the
AstraDB
vector store component. The most significant changes include the introduction of a newNestedDictInput
for advanced search filters, improvements to how search arguments are built, and better error handling during the search process.Enhancements to search filters and arguments:
NestedDictInput
foradvanced_search_filter
and deprecated the existingsearch_filter
(src/backend/base/langflow/components/vectorstores/astradb.py
)._build_search_args
method to clean and validate search filters, and to log deprecated usage ofsearch_filter
(src/backend/base/langflow/components/vectorstores/astradb.py
).Error handling and logging improvements:
search_documents
method by adding specific error messages and logging steps (src/backend/base/langflow/components/vectorstores/astradb.py
).Codebase improvements:
_cached_vector_store
toAstraVectorStoreComponent
(src/backend/base/langflow/components/vectorstores/astradb.py
).AstraDBVectorStore
andNestedDictInput
(src/backend/base/langflow/components/vectorstores/astradb.py
).