Prevent Default on Ctrl + Backspace in ReactFlow #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation to improve user experience 🐛 fix(AccordionComponent/index.tsx): prevent default behavior of Backspace key to improve user experience 🐛 fix(floatComponent/index.tsx): prevent default behavior of Backspace key to improve user experience 🐛 fix(inputComponent/index.tsx): prevent default behavior of Backspace key to improve user experience 🐛 fix(inputListComponent/index.tsx): prevent default behavior of Ctrl+Backspace key combination to improve user experience 🐛 fix(intComponent/index.tsx): prevent default behavior of Backspace key to improve user experience 🐛 fix(genericModal/index.tsx): prevent default behavior of Backspace key to improve user experience
🐛 fix(frontend): remove unnecessary merge conflict markers in reactflowUtils.ts file
… the application to improve user experience
|
Waiting for definitions to finish the Pull Request. |
…+backspace event The code related to preventing the control+backspace event in the application was removed as it was no longer needed.
…and improve code semantics feat(reactflowUtils.ts): add getConnectedNodes function to retrieve connected nodes based on an edge fix(styleUtils.ts): remove unused getConnectedNodes function
anovazzi1
requested changes
Aug 4, 2023
…on of keyboard event when pressing Ctrl + Backspace on input value that matches block or ends with a space character to improve user experience
Could you please double-check if everything is alright now? |
ogabrielluiz
requested changes
Aug 11, 2023
…characters in strings 🔧 fix(reactflowUtils.ts): update handleKeyDown function to prevent deletion of block when a special character is the last character in the input value
Please, kindly reevaluate to confirm if the bug has been resolved at this point. |
…event in handleKeyDown function 🐛 fix(reactflowUtils.ts): fix handleKeyDown function to properly handle special characters and backspace key
…ion on Windows/Linux and Mac
…sRegex to include them as special characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where using Ctrl + Backspace in ReactFlow caused unwanted default behavior. This pull request addresses the problem by preventing the default action when the user presses Ctrl + Backspace, allowing for a smoother and more intuitive experience when interacting with the application.
🐛 fix(App.tsx): prevent default behavior of Ctrl+Backspace key combination to improve user experience
🐛 fix(AccordionComponent/index.tsx): prevent default behavior of Backspace key to improve user experience
🐛 fix(floatComponent/index.tsx): prevent default behavior of Backspace key to improve user experience
🐛 fix(inputComponent/index.tsx): prevent default behavior of Backspace key to improve user experience
🐛 fix(inputListComponent/index.tsx): prevent default behavior of Ctrl+Backspace key combination to improve user experience
🐛 fix(intComponent/index.tsx): prevent default behavior of Backspace key to improve user experience
🐛 fix(genericModal/index.tsx): prevent default behavior of Backspace key to improve user experience