-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Object to JsonLDObject (Fix PHP 7.2) #92
Conversation
Don't assume its an array
Of interest to @acoburn and @DiegoPino |
+1. We are also struggling with 7.2 compatibility, merging this into an official release available via Composer would help a lot! |
@lanthaler If there is something I can do to make this easier, please let me know. I realize that you may not want to use |
We also encountered this problem while using api-platform with this plugin to generate the PHP classes. |
same problem, please merge this PR |
Hi @lanthaler, 6 months in and there has been no response on this PR. Is there something I can do to help move this forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an excellent way to address the php7.2 issues mentioned.
@lanthaler I know you are very busy dealing with JSON-LD 1.1 specs and your day job too, but it would mean a great deal to us == highly appreciated == if you could review/merge this pull. Many of us are using this package (great one) on current and future larger community-driven Open Source projects and having PHP 7.2 support is crucial. Thanks! |
Yay, finally! Thanks a lot @lanthaler! |
@lanthaler++ thanks a lot |
Thank you @lanthaler, I would have been happy to make the desired changes but either way I am glad to get this working. Cheers. |
No worries. I had a couple of hours and wanted to get as much done as possible :-) |
Similar to #79 but doesn't switch back to use
stdClass()
but instead changes the oldObject
name toJsonLDObject
. Also fixes two locations where arrays were assumed for uses ofcount()
but tests fail.This is also starting to hit the limits of using PHPUnit 4, I'd recommend dropping some of the older versions of PHP from the support matrix.