Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace an inappropriate test expression that is always evaluating to true #1529

Conversation

munahaf
Copy link
Contributor

@munahaf munahaf commented Aug 29, 2023

In file: rapiddns.py, the comparison of Collection length creates a logical short circuit; it will always evaluate to true. I suggested that the Collection length comparison should be done without creating a logical short circuit. The check is likely to be done only if the cells is of non-zero length. This is what I introduced.

Sponsorship and Support:

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF)(https://openssf.org/): Project Alpha-Omega(https://alpha-omega.dev/). Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

@L1ghtn1ng L1ghtn1ng merged commit e341d19 into laramies:master Aug 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants