Fix ip-address parsing for IPv6 addresses #1670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the host string uses IPv6 instead of IPv4, so the address has colons. This can result in a string like
google.com:2607:f8b0:4006:80b::200e
If we then run
subdomain, addr = host.split(":")
host.split(":")
returns a list of seven strings because their are six colons. Setting(subdomain, addr)
to a list of seven strings doesn't work (ValueError: too many values to unpack (expected 2)
). What we really want here issubdomain, addr = host.split(":", 1)
which splits only on the first colon, so a list of two strings is returned, and the whole IPv6 address gets assigned to the
addr
variable.