Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11.x Compatibility #153

Merged

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.

Before merging, you need to:

  • Checkout the l11-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

ℹ️ Shift detected you do not have a CI workflow using GitHub Actions. If you would like, Shift can help you get started with the CI Generator. Although the Shift is paid, GitHub Actions is free and having a CI workflow will improve the stability and review process for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/onesignal.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "laravel-notification-channels/onesignal": "dev-l11-compatibility",
    }
}

Finally, run: composer update

@mbardelmeijer
Copy link
Contributor

@LKaemmerling would you mind taking a look at this PR to add support for Laravel 11? Thanks 🙏

Perhaps good to merge #150 into that release as well.

@midblep
Copy link

midblep commented Mar 27, 2024

In need of this as well

@ejunker
Copy link

ejunker commented Mar 27, 2024

@atymic would you be able to help us get these merged so it can work with Laravel 11? This PR and also #150 I'm excited to upgrade but this is the last remaining package that I use that is not compatible.

@atymic atymic merged commit 9f85640 into laravel-notification-channels:master Apr 1, 2024
1 check passed
@ejunker
Copy link

ejunker commented Apr 1, 2024

@atymic thank you so much for getting this working with Laravel 11. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants