Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Adjust documentation to use new Laravel Sail supervisord environment substitution support #9229

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

bram-pkg
Copy link
Contributor

@bram-pkg bram-pkg commented Dec 29, 2023

This should be merged after laravel/sail#645 is released

@bram-pkg bram-pkg changed the title [10.x [10.x] Adjust documentation to use new Laravel Sail supervisord environment substitution support Dec 29, 2023
@bram-pkg bram-pkg marked this pull request as draft December 29, 2023 23:30
@bram-pkg
Copy link
Contributor Author

bram-pkg commented Dec 29, 2023

@taylorotwell here is the PR which documents the new environment variable for Sail's SUPERVISOR_PHP_COMMAND.

What do you think about also assuming people have the sail alias? Would clean up this document a bit, I think.

@bram-pkg bram-pkg marked this pull request as ready for review December 29, 2023 23:45
@taylorotwell taylorotwell marked this pull request as draft January 1, 2024 15:25
@taylorotwell taylorotwell marked this pull request as ready for review January 9, 2024 11:47
@taylorotwell taylorotwell merged commit 8e5d69c into laravel:10.x Jan 9, 2024
@bram-pkg bram-pkg deleted the patch-1 branch January 9, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants