Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hasHeadlessDisabled() and shouldStartMaximized() to Laravel\Dusk\TestCase #1098

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Apr 16, 2024

We don't typically change this configuration. It shouldn't be in the stubs file.

@driesvints
Copy link
Member

@crynobone tests fail here

@driesvints driesvints marked this pull request as draft April 16, 2024 06:28
@crynobone crynobone changed the title Move hasHeadlessDisabled() and shouldStartMaximized() to Move hasHeadlessDisabled() and shouldStartMaximized() to Laravel\Dusk\TestCase Apr 16, 2024
@crynobone crynobone marked this pull request as ready for review April 16, 2024 07:49
`Laravel\Dusk\TestCase`.

We don't typically change this configuration. It shouldn't be in the
stubs file.

Signed-off-by: Mior Muhammad Zaki <[email protected]>
@taylorotwell taylorotwell merged commit 6aa3fcf into 8.x Apr 16, 2024
18 checks passed
@taylorotwell taylorotwell deleted the simplify-stubs branch April 16, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants