Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Add latest version of Facebook Webdriver #654

Merged

Conversation

marcusmyers
Copy link
Contributor

Due to the latest version of the Chromedriver using W3C protocol by
default, this commit requires the latest version of
facebook/webdriver. The latest version forces the Chromedriver to not
use the W3C protocol by default.

This commit will fix issue #651.

Due to the latest version of the Chromedriver using W3C protocol by
default, this commit requires the latest version of
`facebook/webdriver`. The latest version forces the Chromedriver to not
use the W3C protocol by default.

This commit will fix issue laravel#651.
@driesvints driesvints changed the title Add latest version of Facebook Webdriver [5.0] Add latest version of Facebook Webdriver Jun 13, 2019
@taylorotwell taylorotwell merged commit f2b9090 into laravel:5.0 Jun 13, 2019
@marcusmyers marcusmyers deleted the add-latest-version-of-facebook-webdriver branch June 14, 2019 00:56
@jorgenb
Copy link

jorgenb commented Jun 26, 2019

Pardon my ignorance, but how do I actually get the latest version of facebook/webdriver installed in an existing code base? Should I composer require it?

cat composer.json
{
    "name": "laravel/laravel",
    "type": "project",
    "description": "The Laravel Framework.",
    "keywords": [
        "framework",
        "laravel"
    ],
    "license": "MIT",
    "repositories": [
        {
            "type": "composer",
            "url": "https://nova.laravel.com"
        },
        {
            "type": "path",
            "url": "./nova-components/NovaTheme"
        }
    ],
    "require": {
        "php": "^7.1.3",
        "bensampo/laravel-enum": "^1.19",
        "fideloper/proxy": "^4.0",
        "guzzlehttp/guzzle": "^6.3",
        "laravel/framework": "5.8.*",
        "laravel/horizon": "^3.2",
        "laravel/nova": "~2.0",
        "laravel/passport": "^7.2",
        "laravel/socialite": "^4.1",
        "laravel/telescope": "^2.0",
        "laravel/tinker": "^1.0",
        "lorisleiva/laravel-deployer": "^0.2.11",
        "owen-it/laravel-auditing": "^9.0",
        "rette/nova-theme": "dev-52-rts-22313-nova-theme",
        "socialiteproviders/dataporten": "^2.1",
        "spatie/laravel-model-status": "^1.7",
        "spatie/laravel-permission": "^2.36",
        "thepinecode/policy": "^0.1.2",
        "vyuldashev/nova-permission": "^1.4",
        "webpatser/laravel-uuid": "^3.0"
    },
    "require-dev": {
        "beyondcode/laravel-dump-server": "^1.0",
        "filp/whoops": "^2.0",
        "fzaninotto/faker": "^1.4",
        "laravel/dusk": "^5.0",
        "mockery/mockery": "^1.0",
        "nunomaduro/collision": "^3.0",
        "phpunit/phpunit": "^7.5",
        "squizlabs/php_codesniffer": "^3.4",
        "staudenmeir/dusk-updater": "^1.0"
    },
    "config": {
        "optimize-autoloader": true,
        "preferred-install": "dist",
        "sort-packages": true
    },
    "extra": {
        "laravel": {
            "dont-discover": []
        }
    },
    "autoload": {
        "psr-4": {
            "App\\": "app/"
        },
        "classmap": [
            "database/seeds",
            "database/factories"
        ]
    },
    "autoload-dev": {
        "psr-4": {
            "Tests\\": "tests/"
        }
    },
    "minimum-stability": "dev",
    "prefer-stable": true,
    "scripts": {
        "post-autoload-dump": [
            "Illuminate\\Foundation\\ComposerScripts::postAutoloadDump",
            "@php artisan package:discover --ansi"
        ],
        "post-root-package-install": [
            "@php -r \"file_exists('.env') || copy('.env.example', '.env');\""
        ],
        "post-create-project-cmd": [
            "@php artisan key:generate --ansi"
        ]
    }
}

@staudenmeir
Copy link
Contributor

@jorgenb Run composer update.

@jorgenb
Copy link

jorgenb commented Jun 26, 2019

Should that be composer update facebook/webdriver or just composer update? Not too comfortable with the latter.

@marcusmyers
Copy link
Contributor Author

@jorgenb simply run composer update laravel/dusk that should install the latest facebook/webdriver package.

@jorgenb
Copy link

jorgenb commented Jun 26, 2019

I tried composer update laravel/dusk. It did not update facebook/webdriver. When I run composer update facebook/webdriver it bumps the version:

git diff composer.lock
diff --git a/composer.lock b/composer.lock
index 122f962..3893f8b 100644
--- a/composer.lock
+++ b/composer.lock
@@ -3306,7 +3306,8 @@
             "dist": {
                 "type": "path",
                 "url": "./nova-components/NovaTheme",
-                "reference": "dc0ed03e6b0821aacac27450b722ade73809fef5"
+                "reference": "dc0ed03e6b0821aacac27450b722ade73809fef5",
+                "shasum": null
             },
             "require": {
                 "php": ">=7.1.0"
@@ -5298,16 +5299,16 @@
         },
         {
             "name": "facebook/webdriver",
-            "version": "1.6.0",
+            "version": "1.7.1",
             "source": {
                 "type": "git",
                 "url": "https://github.com/facebook/php-webdriver.git",
-                "reference": "bd8c740097eb9f2fc3735250fc1912bc811a954e"
+                "reference": "e43de70f3c7166169d0f14a374505392734160e5"
             },
             "dist": {
                 "type": "zip",
-                "url": "https://api.github.com/repos/facebook/php-webdriver/zipball/bd8c740097eb9f2fc3735250fc1912bc811a954e",
-                "reference": "bd8c740097eb9f2fc3735250fc1912bc811a954e",
+                "url": "https://api.github.com/repos/facebook/php-webdriver/zipball/e43de70f3c7166169d0f14a374505392734160e5",
+                "reference": "e43de70f3c7166169d0f14a374505392734160e5",
                 "shasum": ""
             },
             "require": {
@@ -5354,7 +5355,7 @@
                 "selenium",
                 "webdriver"
             ],
-            "time": "2018-05-16T17:37:13+00:00"
+            "time": "2019-06-13T08:02:18+00:00"
         },
         {
             "name": "filp/whoops",
(END)

... and my Dusk tests start working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants