Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Ensure jQuery for scrollTo #686

Merged
merged 1 commit into from
Oct 31, 2019
Merged

[5.x] Ensure jQuery for scrollTo #686

merged 1 commit into from
Oct 31, 2019

Conversation

driesvints
Copy link
Member

Seems this was an oversight in the previous PR.

@driesvints driesvints mentioned this pull request Oct 31, 2019
Merged
@taylorotwell taylorotwell merged commit cfffd19 into 5.0 Oct 31, 2019
@driesvints driesvints deleted the update-scroll-to branch October 31, 2019 13:00
@mbardelmeijer
Copy link
Contributor

Thanks @driesvints! 💪

@lk77
Copy link
Contributor

lk77 commented Nov 6, 2019 •
edited
Loading

Hello,

can you tag this to 5.6.1 ?

we have a scrollTo macro, and since the new scrollTo function, tests are not working cause of missing jquery dependency.

thanks.

@driesvints
Copy link
Member Author

@lk77 will tag tomorrow on release day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@driesvints @mbardelmeijer @lk77 @taylorotwell