Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for Pusher's
pusher:subscription_error
event through a dedicated and genericerror
callback handler. It'll pass along the status as its first argument when a subscription error occurs.I couldn't find any proper docs on Socket.io's events so I wouldn't know what the equivalent is for Socket.io.
@tillkruss noted that this is applicable for Private Channel as well. I noticedhere
is also only applied onPresenceChannel
. I feel like like bothhere
anderror
and maybe evenjoining
,leaving
andwhisper
should too? MaybePrivateChannel
should extendPresenceChannel
? What are your thoughts @taylorotwell?Moving just
.error
to the abstractPusherChannel
class.Because this adds a new method on an interface this probably needs a new major release. Although I don't know what the policy is for Echo so this might just be a minor?
Resolves #177