Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register subscription succeeded callbacks #288

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Register subscription succeeded callbacks #288

merged 3 commits into from
Oct 13, 2020

Conversation

joelbutcher
Copy link
Contributor

@joelbutcher joelbutcher commented Oct 13, 2020 •
edited
Loading

This PR adds a subscriptionSucceeded method to all channels, allowing developers to register a callback for pusher:subscription_succeeded(pusher) and connect (socket.io) events

The NullChannel returns the channel instance without registering a callback.

@taylorotwell taylorotwell merged commit d9b5a09 into laravel:master Oct 13, 2020
@joelbutcher joelbutcher deleted the register-subscription-succeeded-callbacks branch October 14, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelbutcher @taylorotwell