Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Channel, PresenceChannel class to typescript definition exports #333

Merged
merged 4 commits into from
Apr 6, 2022
Merged

add Channel, PresenceChannel class to typescript definition exports #333

merged 4 commits into from
Apr 6, 2022

Conversation

steve3d
Copy link
Contributor

@steve3d steve3d commented Apr 6, 2022 •
edited
Loading

I've created a issue about the Channel, PresenceChannel class should be also exported to typescript definition,

and here is the simple fix for that.

@taylorotwell taylorotwell merged commit 3cdc2cc into laravel:master Apr 6, 2022
@slavarazum slavarazum mentioned this pull request Apr 14, 2022
Closed
@igorrynkovoy
Copy link

That is very good idea... (NO)
Now try to install this package using NPM (also check version) and use it reading Laravel DOC.
@steve3d
Good luck!

@bytestream bytestream mentioned this pull request Jun 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steve3d @igorrynkovoy @taylorotwell