[1.x] Allow the expected email address request variable to be changed #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat contains the email address when making forgot password and password reset requests.
driesvints
requested changes
Sep 12, 2020
driesvints
reviewed
Sep 12, 2020
…mail' to match other apps and packages in the eco system.
driesvints
changed the title
|
@adear11 Taylor will review your PR once he's ready. |
|
I got an email that you commented on this PR, but I can't find your comment. So I'm replying here rather than directly to your comment. I would have expected that what the POST variable was named would not matter. However, that does not appear to be the case. Further down the call stack, the The same thing is true for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests gives the ability to change the expected name of the variable in the request that holds the email address when making requests for forgotten passwords and when setting a new password. As it is implemented currently, the request variable name
emailis hard coded into the controllers for both requesting a password reset link and for setting the new password after visiting the reset link. This pull request adds a new config option, similar to theusernameoption that is currently there, to allow for changing the expected variable name.The implementation maintains the
emailname as a default value so that any existing applications should not experience any BC breaks.The ability to set the expected name of the email address request variable via a config value makes it much easier to integrate a new Laravel application that uses Fortify into an existing system that already has an established database schema that cannot be changed. Without the ability to change that hard coded value via config value, it appears as though the only solution to this problem would be to re-implement all of the password reset logic and controllers simply to change the one request variable.