Add support for password confirmation middleware. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1guelpf
reviewed
Sep 7, 2020
Co-authored-by: Miguel Piedrafita <[email protected]>
|
Well done. This saved me some time today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds controller methods to support the 'password.confirm' middleware from Illuminate/Auth.
The idea here is that this could eventually be used to implement a solution for issues like:
laravel/jetstream#17
laravel/jetstream#20
Where certain high risk actions (deleting an API key, deleting the user account, disabling 2FA, etc) could require a password verification prior to accessing the route. This is the pattern that Github follows (a re-auth redirect), and I think it's the most flexible approach.
Thanks for considering!