[10.x] Prevent session:table command from creating duplicates (#48602)

* Prevent `session:table` command from creating duplicates * Fix `session:table` test mock * Fix Windows paths * Update SessionTableCommand.php --------- Co-authored-by: Taylor Otwell <[email protected]>
laravel · Oct 2, 2023 · cd68b64 · cd68b64
1 parent 388c835
commit cd68b64
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/Illuminate/Session/Console/SessionTableCommand.php b/src/Illuminate/Session/Console/SessionTableCommand.php
@@ -60,6 +60,12 @@ public function __construct(Filesystem $files, Composer $composer)
      */
     public function handle()
     {
+        if ($this->migrationExists()) {
+            $this->components->error('Migration already exists.');
+
+            return 1;
+        }
+
         $fullPath = $this->createBaseMigration();
 
         $this->files->put($fullPath, $this->files->get(__DIR__.'/stubs/database.stub'));
@@ -80,4 +86,16 @@ protected function createBaseMigration()
 
         return $this->laravel['migration.creator']->create($name, $path);
     }
+
+    /**
+     * Determine whether the session table migration already exists.
+     *
+     * @return bool
+     */
+    protected function migrationExists()
+    {
+        return count($this->files->glob(
+            $this->laravel->joinPaths($this->laravel->databasePath('migrations'), '*_*_*_*_create_sessions_table.php')
+        )) !== 0;
+    }
 }
diff --git a/tests/Session/SessionTableCommandTest.php b/tests/Session/SessionTableCommandTest.php
@@ -33,6 +33,7 @@ public function testCreateMakesMigration()
         $command->setLaravel($app);
         $path = __DIR__.'/migrations';
         $creator->shouldReceive('create')->once()->with('create_sessions_table', $path)->andReturn($path);
+        $files->shouldReceive('glob')->once()->with($app->joinPaths($app->databasePath('migrations'), '*_*_*_*_create_sessions_table.php'))->andReturn([]);
         $files->shouldReceive('get')->once()->andReturn('foo');
         $files->shouldReceive('put')->once()->with($path, 'foo');