5.2.40 breaks database queries on HHVM

[iangcarroll]

Upgraded to 5.2.41 and now any database query causes the following error to be thrown on HHVM:

SQLSTATE[HY000]: General error: user-supplied class does not have a constructor, use NULL for the ctor_params parameter, or simply omit it (SQL: [...])

Looks like 5.2.40 introduced the error: https://laracasts.com/discuss/channels/forge/sqlstatehy000-general-error-user-supplied-class-does-not-have-a-constructor

[GrahamCampbell]

What HHVM version please? If the latest, please report this bug to facebook.

[iangcarroll]

We're on 3.12-lts.

[iangcarroll]

Looks like #14052 is the reason this is happening.

[GrahamCampbell]

Still facebook's fault for not being php compatible, but re-opening this since we should probably mitigate this ourselves.

[vlakoff]

I have submitted a fix for this: #14429.

[vlakoff]

HHVM isn't that wrong, as using an empty array is not "documented", in the error message.

Still, it is an incompatibility with PHP.

[GrahamCampbell]

HHVM is wrong if it's not exactly the same as PHP. PHP is the definition of being correct.

[vlakoff]

Fixed by #14429 and Laravel 5.2.42 has been released, so this issue can be closed.