Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Fix PDO connection on HHVM with the default "class without name" case #14429

Merged
merged 1 commit into from
Jul 22, 2016
Merged

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented Jul 22, 2016

HHVM doesn't support using an empty array to omit the 3rd parameter "constructor argument".

Refs #14052 and #14426.

HHVM doesn't support using an empty array to omit the 3rd parameter "constructor argument".
@vlakoff
Copy link
Contributor Author

vlakoff commented Jul 22, 2016

A simpler alternative could be by using:

if ($fetchMode === PDO::FETCH_CLASS && ! isset($fetchArgument)) {
    $fetchMode = PDO::FETCH_OBJ;
}

I was intending to use it in the first place, but changing $fetchMode sounded a bit risky to me.

@taylorotwell taylorotwell merged commit f6a4db4 into laravel:5.2 Jul 22, 2016
@vlakoff vlakoff deleted the pdo-hhvm branch July 23, 2016 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants