Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Add after and before to dependent rules array #13025

Merged
merged 1 commit into from
Apr 6, 2016
Merged

[5.2] Add after and before to dependent rules array #13025

merged 1 commit into from
Apr 6, 2016

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Apr 5, 2016

@taylorotwell taylorotwell merged commit d30ff2b into laravel:5.2 Apr 6, 2016
@themsaid themsaid deleted the validator-dependents branch April 24, 2016 09:52
@vlakoff
Copy link
Contributor

vlakoff commented May 3, 2016

The 4 tests you added here fail on my computer ("Failed asserting that false is true")

@vlakoff
Copy link
Contributor

vlakoff commented May 5, 2016

Not really familiar with the code here, @themsaid do you have an idea what could be the cause of this platform discrepancy?

@themsaid
Copy link
Member Author

themsaid commented May 5, 2016

@vlakoff hmmmm, it's hard to say. I think you'll need to trace the issue in validateAfter and validateBefore to see why they're failing, maybe it's related to using the year 2046 in the tests, but not sure at all.

@vlakoff
Copy link
Contributor

vlakoff commented May 5, 2016

Good catch, I tested on a 32-bit PHP. Will check this.

@vlakoff
Copy link
Contributor

vlakoff commented May 5, 2016

Yep, that's it.

Max working value is 2038-01-19, as we will be very sad at 03:14:07 UTC on 19 January 2038 (that's only 22 years!).

Do you want to PR this?

@themsaid
Copy link
Member Author

themsaid commented May 5, 2016

Yup, I don't even know why I used 2046 :D It was totally random, maybe it's a sign something will happen that year, hopefully something good.

I'll fix that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants