Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Enabling array on method has() #13028

Merged
merged 3 commits into from
Apr 7, 2016
Merged

Conversation

urameshibr
Copy link
Contributor

No description provided.

@@ -308,9 +308,17 @@ public function ageFlashData()
/**
* {@inheritdoc}
*/
public function has($name)
public function has($key)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert the rename

@GrahamCampbell GrahamCampbell changed the title Enabling array on method has() [5.2] Enabling array on method has() Apr 5, 2016
@dlimars
Copy link

dlimars commented Apr 6, 2016

👍

@taylorotwell
Copy link
Member

You changed it to ! $this->get(...) ... it used to be ! is_null()... please keep same behavior.

Fix return behavior
@taylorotwell taylorotwell merged commit 8f5ce59 into laravel:5.2 Apr 7, 2016
taylorotwell pushed a commit that referenced this pull request Apr 27, 2016
* Added release notes for v5.2.31

* Fixed missing link for #13028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants