[5.2] Fix an issue with fluent routes with uses() #13076
Conversation
| @@ -613,7 +613,7 @@ protected function mergeGroupAttributesIntoRoute($route) | |||
| * @param array $action | |||
| * @return bool | |||
| */ | |||
| protected function actionReferencesController($action) | |||
| public function actionReferencesController($action) | |||
There was a problem hiding this comment.
hmmm, could you explain please? how changing the visibility to public can lead to breaking things? It's 1:00 AM here and I should probably go to sleep but this one is pretty confusing to me
There was a problem hiding this comment.
protected methods can be overwritten by a parent class, and modifying the visibility to public will cause a fatal error if this method has been overwritten by parent class
There was a problem hiding this comment.
I think you mean overwritten as protected by a child class, so yeah changing this to public will cause a fatal in case anyone is overwriting the Router. Alright, thanks for the notes 👍
|
Should we add a test case for this? |
|
I've already added two tests to check for the controller action after using |
|
Got it! Thanks |
As reported in #13074.
This PR fixes the issue with routing using
->uses('Controller@method').